Task #38972

Improve method makeCategorizable to be used everywhere

Added by Fabien Udriot 10 months ago. Updated 8 days ago.

Status:Resolved Start date:2012-07-16
Priority:Should have Due date:
Assignee:Fabien Udriot % Done:

100%
Category:-
Target version:6.2.0
TYPO3 Version:6.0 Complexity:
PHP Version:5.3
Votes: 1 (View)

Description

Method makeCategorizable is in charge of registering a table to be categorizable in the BE. The current implementation has the drawback to force the call of this method after the TCA of the table. If called before, the "categorization" wouldn't be applied because of timing issue. The patch improve the situation in this regard by postponing the application of the TCA responsible of categorization.

For more details about the method refer to t3lib_extMgm::makeCategorizable.

Related issues

related to Core - Bug #48381: after git pull db compare -> CREATE TABLE ( ( categories ... Under Review 2013-05-19

Associated revisions

Revision 0022e3a9
Added by Fabien Udriot 8 days ago

[TASK] Improve method makeCategorizable to be used everywhere

Method makeCategorizable registers a table to be categorizable in the
BE. The current implementation has the drawback to force the call of this
method after the TCA of the table. If called before, the "categorization"
wouldn't be applied because of timing issue. The patch improve the
situation by postponing the application of the TCA responsible for
categorization.

For more details about the method refer to
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::makeCategorizable.

Change-Id: I966cc65e50e0d6a81cfafb1238f253ed802349c6
Resolves: #38972
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12812
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Revision c7b99a8c
Added by Fabien Udriot 8 days ago

[TASK] Improve method makeCategorizable to be used everywhere

Method makeCategorizable registers a table to be categorizable in the
BE. The current implementation has the drawback to force the call of this
method after the TCA of the table. If called before, the "categorization"
wouldn't be applied because of timing issue. The patch improve the
situation by postponing the application of the TCA responsible for
categorization.

For more details about the method refer to
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::makeCategorizable.

In addition to 6.2, the Install Tool setting
[SYS][defaultCategorizedTables] is set to an empty string to avoid
requirering DB updates for minor releases.

Change-Id: I966cc65e50e0d6a81cfafb1238f253ed802349c6
Resolves: #38972
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/20767
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter

History

#1
Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12812

#2
Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12812

#3
Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12812

#4
Updated by Helmut Hummel 4 months ago

  • Target version changed from 6.0.0-alpha3 to 6.0.1

#5
Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#6
Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#7
Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#8
Updated by Gerrit Code Review 10 days ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#9
Updated by Gerrit Code Review 10 days ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#10
Updated by Fabien Udriot 10 days ago

  • Target version changed from 6.0.1 to 6.2.0
  • PHP Version set to 5.3

To test the patch you could make this experiment. Before applying the patch, in extension "foo", add this line at the top of ext_tables.php and notice there are no categories key in TCA['foo']['columns'] Edit: Actually after a second test, it appears categorization is totally broken as of 6.1 following TCA refactoring. Patch resolves it.

# Actually, I have taken EXT:news/ext_tables.php as example
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::makeCategorizable('news', 'tx_news_domain_model_file');

After applying the patch, you will see a field "categories" in TCA of table "foo" proving the use of the patch.

#11
Updated by Gerrit Code Review 9 days ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#12
Updated by Gerrit Code Review 9 days ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12812

#13
Updated by Francois Suter 9 days ago

While looking at your patch, I discovered the [SYS][defaultCategorizedTables] setting which isn't documented in the wiki. It doesn't work at all unless your patch is applied.

By default it is set to "pages,tt_content". If your patch is backported as is to 6.1, categories will suddenly appear in the pages and tt_content tables upon the next minor upgrade, but the database will not have been updated, thus creating SQL errors. I would suggest to remove this default setting from 6.1 and leave it only for 6.2.

I will open a thread in the core list about this.

#14
Updated by Fabien Udriot 8 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15
Updated by Gerrit Code Review 8 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/20767

#16
Updated by Fabien Udriot 8 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF