PHPUnit

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

I am unsure though, whether we should add a TYPO3 minimum version... Probably not, it doesn't hurt to have a few (sys_) empty tables for T3 version < 6.0, IMO

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

1. rename the new columns to "tx_phpunit_is_dummy_record"

Done

2. add unit tests that these system tables can be created by the framework (you'll need to add them to Tx_Phpunit_Framework.allowedSystemTables) - you can copy'n'paste from the unit tests for the other system tables

Done. Hope I did the "copy'n'paste" correctly. On the top of that, I updated the Test Case from Gerrit patch 12789 . I can confirm it is working as expected with this patch apply in ext:phpunit. :) There is another Test Case somewhere in the Gerrit queue that I will change once this one is approved.

3. Please test that it works to first create the new tables via the EM in phpunit, and then update to 6.0. I remember that this might post a problem when creating the uid column, but haven't verified this yet.

You were right! It seems there is an issue if the tx_phpunit_is_dummy_record field is created before the upgrade (sys_file_* being created without the uid at first). Actually, I had to run the update twice in the install tool to achieve a proper table definition. As said, at the second run the issue disappeared.

Message from the install tool after the first update (problem is with the auto_increment which is not set correctly at first because of an already existing field?)

ALTER TABLE sys_file CHANGE uid uid int(11) auto_increment;
Current value: int(11) default NULL

You were right! It seems there is an issue if the tx_phpunit_is_dummy_record field is created before the upgrade (sys_file_* being created without the uid at first). Actually, I had to run the update twice in the install tool to achieve a proper table definition. As said, at the second run the issue disappeared.

Then this is okay IMHO.

I would say that too (since affecting mainly development instances)

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12830