Bug #39063

Exclude variables $MCONF, $MLANG and $SOBE

Added by Marvin 10 months ago. Updated 8 months ago.

Status:Closed Start date:2012-07-18
Priority:Should have Due date:
Assignee:Andy Grunwald % Done:

0%
Category:NamingConventions Spent time: -
Target version:0.0.4
Branch:v4 Tags:
Votes: 0

Description

In PHP_CodeSniffer, the variables should

$MCONF -> t3lib_loadModules::checkMod
$MLANG -> t3lib_loadModules::checkMod
$SOBE -> t3lib_modSettings::addToStoreListFromPrefix

code to be excluded as sniffer errors "variablename must be lowerCamelCase; expect '$Sobe' but found '$SOBE' " to avoid.

The sniff test of the words is

TYPO3.NamingConventions.ValidVariableName

Associated revisions

Revision 5531beda
Added by Georg Ringer 8 months ago

[BUGFIX] Exclude variables of core

Exclude variables $MCONF, $MLANG, $SOBE

Change-Id: Id5994526fe7cbea44312d744ff85ea3d21c65318
Resolves: #39063
Releases: 0.0.4

History

#1
Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14855

#2
Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14855

#3
Updated by Andy Grunwald 8 months ago

  • Category set to NamingConventions
  • Status changed from Under Review to Resolved
  • Assignee set to Andy Grunwald
  • Target version set to 0.0.4
  • Branch set to v4

Merged.

#4
Updated by Stefano Kowalke 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF