Task #39255

reflectionService property in AbstractViewHelper should be protected instead of private

Added by Aske Ertmann 10 months ago. Updated 10 months ago.

Status:Resolved Start date:2012-07-25
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:Core
Target version:TYPO3 Flow Base Distribution - 2.0 beta 1
Has patch:Yes
Votes: 1 (View)

Description

The property "reflectionService" in the AbstractViewHelper should be protected instead of private to allow usage of the reflection service in view helpers without having to inject again with another property name.

Needed here: https://review.typo3.org/#/c/9695 - see general comments and comments here https://review.typo3.org/#/c/9695/2/Classes/ViewHelpers/Widget/CommentsViewHelper.php

Associated revisions

Revision 4b3c0967
Added by Aske Ertmann 10 months ago

[TASK] Make reflectionService property in AbstractViewHelper protected

The property "reflectionService" in the AbstractViewHelper should be
protected instead of private to allow usage of the reflection service in
view helpers without having to inject again with another property name.

Change-Id: I438e2d98c2c1cf31c4db73ef28130eebb24c9782
Resolves: #39255
Releases: 1.2

History

#1
Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13042

#2
Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13042

#3
Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13042

#4
Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13042

#5
Updated by Anonymous 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 90 to 100

Also available in: Atom PDF