Bug #39428

Layout and partial identifiers should be independent of current controller name

Added by Alexander Berl 11 months ago. Updated 2 months ago.

Status:Under Review Start date:2012-07-31
Priority:Must have Due date:
Assignee:Alexander Berl % Done:

0%
Category:Core
Target version:TYPO3 Flow Base Distribution - 1.1.2
Has patch:No FLOW3 version affected:FLOW3 1.1.0 rc 2
Votes: 0

Description

Currently, all templates get an identifier made up of package/subpackage, controller, prefix and unique hash.
This leads to all layouts and partials being compiled and cached once for each controller they are used from, even though the contents is independant and hence just a duplicate.

I suggest adding the controller name as part of the prefix in getTemplateIdentifier() only and stripping it from createIdentifierForFile().

History

#1
Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13391

#2
Updated by Karsten Dambekalns 11 months ago

  • Category set to Core
  • Assignee set to Alexander Berl
  • Target version set to 1.1

#3
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13391

#4
Updated by Karsten Dambekalns 10 months ago

  • Target version changed from 1.1 to 1.1.1

#5
Updated by Karsten Dambekalns 6 months ago

  • Target version changed from 1.1.1 to 1.1.2

#6
Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13391

#7
Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13391

Also available in: Atom PDF