Bug #39617

Email View Helper: Problems with spamProtectEmailAddresses = ascii

Added by Daniel Baur 10 months ago. Updated 6 months ago.

Status:Closed Start date:2012-08-08
Priority:-- undefined -- Due date:
Assignee:- % Done:

0%
Category:Fluid: ViewHelpers
Target version:-
Complexity:
Votes: 0

Description

When using the fluid email view helper and having spamProtectEmailAddresses = ascii enabled, the link to the mail address will not work.

While the call to list($linkHref, $linkText) = $GLOBALS['TSFE']->cObj->getMailTo($email, $email); in the render method of the view helper works fine, the $this->tag->addAttribute('href', $linkHref); call causes the problem.

As the add attribute call will escape the ascii chars using the htmlspecialchars method, the browser will not correctly interpret the ascii chars.

Possible solution: do not escape the href attribute when spamProtectEmailAddresses = ascii is set.

Related issues

duplicates Fluid - Bug #7453: EmailViewHelper renders escaped href - link would not wor... Resolved 2010-04-23

History

#1
Updated by Daniel Baur 10 months ago

another possibility would be to escape the email before passing it to the getMailTo method, and then using $this->tag->addAttribute with escapeSpecialCharacters set to false.

#2
Updated by Daniel Baur 10 months ago

  • Project changed from TYPO3.Fluid to Extbase MVC Framework
  • Category deleted (ViewHelpers)

#3
Updated by Ingo Pfennigstorf 9 months ago

  • Category set to 963
  • Status changed from New to Accepted
  • Target version set to Extbase 6.0

Reproducable behaviour.

#4
Updated by Gerrit Code Review 9 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14438

#5
Updated by Ingo Pfennigstorf 9 months ago

  • Has patch changed from No to Yes

#6
Updated by Marc Bastian Heinrichs 9 months ago

Should be fixed with Bastians suggestion in #7453 covered with a unit test

#7
Updated by Marc Bastian Heinrichs 9 months ago

  • Status changed from Under Review to Closed
  • Priority changed from Should have to -- undefined --
  • Target version deleted (Extbase 6.0)
  • Has patch changed from Yes to No

Close this as duplicate of #7453

#8
Updated by Gerrit Code Review 9 months ago

  • Status changed from Closed to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14438

#9
Updated by Ingo Pfennigstorf 9 months ago

  • Status changed from Under Review to Closed

Reclosed as duplicate

#10
Updated by Anja Leichsenring 6 months ago

  • Project changed from Extbase MVC Framework to Fluid
  • Category changed from 963 to Fluid: ViewHelpers

Also available in: Atom PDF