Bug #39619
Remove all dependencies on HTTP_HOST
| Status: | New | Start date: | 2012-08-08 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | |||
| Target version: | 1.3.2 | |||
| Votes: | 0 |
Description
We sometimes rely on HTTP_HOST to find domain name. But this is not available when sending newsletter via scheduler (via CLI), so this cannot be used at all. Currently it wrongly give the impression that everything is configured properly (including test newsletter), until we actually send something via CLI.
We also need a proper way to tell the user about that situation when setting up the extension for the first time. It should be shown via flash messages but it does not work out of the box as expected. More debugging is needed.
History
Updated by Adrien Crivelli 6 months ago
Somewhat related to this issue is https://github.com/Ecodev/newsletter/commit/010cac2b5471c1ba4e43ad28e508f9dbc972af72. HTTP_HOST must never be used as a source but rather as destination of data, as long as other $_SERVER vars, to help TYPO3 generate correct links.
Updated by Adrien Crivelli 2 months ago
- Target version changed from 1.3.1 to 1.3.2
Postponed to next version, so we can release 1.3.1 earlier.