Feature #39638

respect box width and height in gifbuilder imagesize

Added by Kjeld Schumacher 10 months ago. Updated 22 days ago.

Status:Under Review Start date:2012-08-09
Priority:Could have Due date:
Assignee:- % Done:

0%

Category:Image Generation
Target version:4.7.3
TYPO3 Version:4.7 Complexity:
PHP Version:5.3
Votes: 0

Description

Hi,

this feature adds the possibility to use the BOX width and height dimensions in gifbuilder imagesize calculation.

At this time TYPO3 does not take the dimensions into account due to the lack of the BoundingBox attribute in the gifbuilder calcOffset function.

The solution is pretty simple, add the missing BoundingBox attribute at the beginning of image creation. Just use the calcOffset function to calculate the BOX width and height and add the result to the BoundingBox attribute.

list($x, $y, $width, $height) = explode(',', $conf['dimensions']);
$this->objBB[$theKey] = explode(',', $this->calcOffset($width . ',' . $height));
break;

History

Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13564

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Updated by Philipp Gampe 4 months ago

Do you have some sample TS to test the code?

Updated by Gerrit Code Review 22 days ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Also available in: Atom PDF