Bug #39681

Warning about property injection not being autowired in functional test

Added by Karsten Dambekalns 9 months ago. Updated 9 months ago.

Status:Resolved Start date:2012-08-10
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:- Testing -
Target version:TYPO3 Flow Base Distribution - 1.1
PHP Version: Complexity:
Has patch:No FLOW3 version affected:FLOW3 1.1.0 rc 2
Votes: 0

Description

The DependencyInjectionTest testcase has a test called injectionInParentClassIsDoneOnlyOnceOnCreationOfObject, leading to FLOW3 trying to use the inject method for the property "ionInParentClassIsDoneOnlyOnceOnCreationOfObject"…

Associated revisions

Revision a7fdef84
Added by Karsten Dambekalns 9 months ago

[BUGFIX] Fix warning about property injection in test

The DependencyInjectionTest testcase has a test called
injectionInParentClassIsDoneOnlyOnceOnCreationOfObject, leading to FLOW3
trying to use the inject method for the property
"ionInParentClassIsDoneOnlyOnceOnCreationOfObject"…

This change renames the test method to fix this.

Change-Id: Ic26fe8b0e960a4b5f1de34a7d7eb6ea53bae56d8
Fixes: #39681
Releases: 1.1, 1.2

Revision 637e604d
Added by Karsten Dambekalns 9 months ago

[BUGFIX] Fix warning about property injection in test

The DependencyInjectionTest testcase has a test called
injectionInParentClassIsDoneOnlyOnceOnCreationOfObject, leading to FLOW3
trying to use the inject method for the property
"ionInParentClassIsDoneOnlyOnceOnCreationOfObject"…

This change renames the test method to fix this.

Change-Id: Ic26fe8b0e960a4b5f1de34a7d7eb6ea53bae56d8
Fixes: #39681
Releases: 1.1, 1.2

Revision 45f872a5
Added by Bastian Waidelich 9 months ago

[TASK] Detect inject methods more strictly

Currently every method starting with "inject" is considered
for property injection by the ConfigurationManager.
That includes methods named "inject" or "injectionFoo".

This change makes the detection more strict to only accept
methods that start with "inject" followed by an upper case
character.

Change-Id: Iada3a11a9831b4c08cb93d2809c6d05c2017bd68
Related: #39681
Releases: 1.2

History

#1
Updated by Gerrit Code Review 9 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13561

#2
Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/13563

#3
Updated by Karsten Dambekalns 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF