Bug #39733
problem with spy links in plain text mails
| Status: | Closed | Start date: | 2012-08-12 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Adrien Crivelli | % Done: | 100% |
|
| Category: | - | |||
| Target version: | 1.3.1 | |||
| Votes: | 0 |
Description
Hi,
consider the following plain text content;
"this is a small line with a link http://www.bla.it/contact/, and another link too; http://www.bla.it/contact/max/"
function injectLinkSpy will produce following link for "http://www.bla.it/contact/max/" in plain text mode;
http://www.mysite.it/?tx_newsletter_p%5Baction%5D=clicked&tx_newsletter_p%5Bcontroller%5D=Link&type=1342671779&url=http%3A%2F%2Fwww.bla.it%2Fcontact%2F&l=f766f8b9089e6c060bd3c48a573054ce&p=1max/
which is wrong. Attached patch substitutes only the relevant parts in plain text content.
History
Updated by Adrien Crivelli 4 months ago
- Status changed from New to Closed
- Assignee set to Adrien Crivelli
- Priority changed from Should have to Must have
- Target version set to 1.3.1
- % Done changed from 0 to 100
Thanks for your contribution, the patch was applied in https://github.com/Ecodev/newsletter/commit/4fb00ba2781bd75503298ca8f4a3b0f8f75219d8
For the record, this was the results before the patch:
[15] http://introductionpackage.local/?tx_newsletter_p%5Baction%5D=clicked&tx_newsletter_p%5Bcontroller%5D=Link&type=1342671779&url=http%3A%2F%2Fwww.bla.it%2Fcontact%2F&l=04b1367e36e1b5ef5ddd47663f629694&p=1 [16] http://introductionpackage.local/?tx_newsletter_p%5Baction%5D=clicked&tx_newsletter_p%5Bcontroller%5D=Link&type=1342671779&url=http%3A%2F%2Fwww.bla.it%2Fcontact%2F&l=04b1367e36e1b5ef5ddd47663f629694&p=1max/"
And this is after:
[15] http://introductionpackage.local/?tx_newsletter_p%5Baction%5D=clicked&tx_newsletter_p%5Bcontroller%5D=Link&type=1342671779&url=http%3A%2F%2Fwww.bla.it%2Fcontact%2F&l=04b1367e36e1b5ef5ddd47663f629694&p=1 [16] http://introductionpackage.local/?tx_newsletter_p%5Baction%5D=clicked&tx_newsletter_p%5Bcontroller%5D=Link&type=1342671779&url=http%3A%2F%2Fwww.bla.it%2Fcontact%2Fmax%2F&l=04b1367e36e1b5ef5ddd47663f629694&p=1
Notice the "max/" segment which was not correctly included in the url.