Task #39977

Allow oneliners for throw statements

Added by Rens Admiraal 9 months ago. Updated 21 days ago.

Status:Rejected Start date:2012-08-19
Priority:Should have Due date:
Assignee:Andy Grunwald % Done:

0%
Category:ControlStructures Spent time: -
Target version:0.0.6
Branch:v5 Tags:typo3flow
Votes: 0

Description

The FLOW3 CGL allows oneline if statements if a throw statement is used: http://flow3.typo3.org/documentation/codingguidelines/php.html#if-statements

For this the sniffing should be loosened a bit to allow the oneliners in those cases

History

#1
Updated by Stefano Kowalke 8 months ago

  • Category set to ControlStructures
  • Status changed from New to Needs Feedback

This topic should discussed first, because it is not part of TYPO3v4 CGL yet. It is not forbidden nor allowed like in FLOW3 CGL . Please open a report at http://forge.typo3.org/projects/typo3v4-doc_core_cgl/issues.

#2
Updated by Rens Admiraal 8 months ago

I don't see why this should be discussed first as I ask for adding the rules to the FLOW3 rulesset.

More important, we spoke about this rule in Copenhagen and we'll probably remove the exception from the cgl. This would mean this issue can be closed. I'll update this issue as soon as I'm sure we'll change the cgl.

#3
Updated by Rens Admiraal 8 months ago

I don't see why this should be discussed first as I ask for adding the rules to the FLOW3 rulesset.

More important, we spoke about this rule in Copenhagen and we'll probably remove the exception from the cgl. This would mean this issue can be closed. I'll update this issue as soon as I'm sure we'll change the cgl.

#4
Updated by Andy Grunwald 8 months ago

  • Target version set to 0.0.5
  • Branch set to v5

#5
Updated by Andy Grunwald 8 months ago

Okay. THX rens.
We will wait for feedback.

#6
Updated by Stefano Kowalke 8 months ago

  • Target version changed from 0.0.5 to 0.0.6

#7
Updated by Rens Admiraal 7 months ago

It is indeed decided to remove this exception, so this one can be closed. We will update the CGL on our website.

#8
Updated by Andy Grunwald 7 months ago

  • Status changed from Needs Feedback to Closed
  • Assignee set to Andy Grunwald

As Rens mentioned the affected change (https://review.typo3.org/#/c/15806/) was merged.
This ticket is not needed anymore.

#9
Updated by Stefano Kowalke 21 days ago

  • Status changed from Closed to Rejected

Nothing to do here.

#10
Updated by Stefano Kowalke 21 days ago

  • Tags set to typo3flow

Also available in: Atom PDF