Bug #41641: t3lib_db StripOrderBy, stripGroupBy fails if clause is misspelled or appears twice. - TYPO3 Core - TYPO3 Forge

Actions

Bug #41641

closed

t3lib_db StripOrderBy, stripGroupBy fails if clause is misspelled or appears twice.

Added by Laurent Cherpit over 11 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

-

Category:

Database API (Doctrine DBAL)

Target version:

-

Start date:

2012-10-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.7

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If ORDER BY or GROUP BY clauses are misspelled or appear twice in the given string. This fails.

Change the expression to be more tolerant and capable to clean, strip the related clauses efficiently.
It could allows to strip that kind of string:

ORDER BY name, tstamp DESC
ORDER BY  name, tstamp DESC
ORDERBY name, tstamp DESC
ORDER BY ORDER BY name, tstamp DESC
ORDERBY ORDER BY  name, tstamp DESC
ORDER BYORDERBY name, tstamp DESC
ORDERBYORDERBY name, tstamp DESC
ORDERBYORDERBYname, tstamp DESC
ORDERBYORDERBY ORDER BY name, tstamp DESC
etc..

Actions

#1

Updated by Gerrit Code Review over 11 years ago

Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions

#2

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions

#3

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions

#4

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions

#5

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions

#6

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15371

Actions

#7

Updated by Laurent Cherpit over 11 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset e68b2e75b44edd41fa5e33e8ca880a072e384f29.

Actions

#8

Updated by Gerrit Code Review over 11 years ago

Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions

#9

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15370

Actions

#10

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/17629

Actions

#11

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17630

Actions

#12

Updated by Gerrit Code Review about 11 years ago

Patch set 5 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/15370

Actions

#13

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17630

Actions

#14

Updated by Laurent Cherpit about 11 years ago

Status changed from Under Review to Resolved

Applied in changeset 46e817e77ac47119afbde5d1d80bd005ad4ad296.

Actions

#15

Updated by Benni Mack over 5 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF