Project

General

Profile

Actions

Bug #43369

closed

Show history in Module Info defect

Added by Bernhard Eckl over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2012-11-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I go to Module -> Info -> Log and click on the history icon. Then I get the following error message:

Not Found

The requested URL /typo3/sysext/info/mod1/show_rechis.php was not found on this server.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #49091: Links to record history details in sysext belog does not workClosed2013-06-13

Actions
Actions #1

Updated by Ingo Pfennigstorf over 11 years ago

can confirm this on current master

Actions #2

Updated by Tobias H. about 11 years ago

  • Target version set to 6.0.3

the bug is in line 57 in this file: typo3\sysext\belog\Classes\ViewHelpers\HistoryEntryViewHelper.php

old: $historyHref = 'show_rechis.php?sh_uid=' . $historyEntry->getUid() . '&returnUrl=' . rawurlencode(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('REQUEST_URI'));

new: $historyHref = '../../../show_rechis.php?sh_uid=' . $historyEntry->getUid() . '&returnUrl=' . rawurlencode(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('REQUEST_URI'));

Actions #3

Updated by Den Denyer about 11 years ago

Actually just experienced this on 4.5.25 also. (Probably irrelevant to you guys, but thought I'd mention it.)

Line 845 of class.show_rechis.inc appears to indicate:

$Ahref = 'show_rechis.php?'.t3lib_div::implodeArrayForUrl('',$params).($anchor?'#'.$anchor:'');

Changing this to:

$Ahref = '../../../show_rechis.php?'.t3lib_div::implodeArrayForUrl('',$params).($anchor?'#'.$anchor:'');

Resulted in a Max Execution Time Exceeded error, which was at least better than a 404 ;) Sadly the server my site is on is buggered right now, so I can't tell you if the above resolves the error, or just introduces a new one.

Either way I'd love to know how to get the revision history working on 4.5.25 as I have some things I desperately need to rollback!!!

Actions #4

Updated by ananth no-lastname-given about 11 years ago

Tobias H. wrote:

the bug is in line 57 in this file: typo3\sysext\belog\Classes\ViewHelpers\HistoryEntryViewHelper.php

old: $historyHref = 'show_rechis.php?sh_uid=' . $historyEntry->getUid() . '&returnUrl=' . rawurlencode(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('REQUEST_URI'));

new: $historyHref = '../../../show_rechis.php?sh_uid=' . $historyEntry->getUid() . '&returnUrl=' . rawurlencode(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('REQUEST_URI'));

the old one worked fine on my system, but i ended up having a problem with xdebug plugin instead..the recursive calls made crossed the limit of 100 and i had to change the limit manually to access the page.. Something similar happened while installing typo3 when the max exec time of 30 seconds was exceeded..

Actions #5

Updated by Andreas Kiessling about 11 years ago

Patch works for me in 6.0.4. Thanks!

Actions #6

Updated by Gerrit Code Review about 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20280

Actions #7

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20280

Actions #8

Updated by Wouter Wolters almost 11 years ago

  • Status changed from Under Review to Resolved

Is merged with #49091

Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF