Bug #4341
Do NOT remove type hinting
| Status: | New | Start date: | 2009-08-26 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Christoph Niewerth | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| Votes: | 0 |
Description
- add the tslib_cObj back to the construtor
- why was loadHtmlFile() changed, revert that change!
http://forge.typo3.org/repositories/diff/extension-tmpl/trunk/classes/class.tx_tmpl.php?rev=23555
Associated revisions
- fix bug: a md5 encoded password must be shown as clear text in the password marker
- fix bug: if enableHTMLMail is 1, then the admin must always receive a HTML email independant from the FE users preferences
- new feature: useLocalCountry to show the country names in their local languages
- remove support for old styled template
- change of subpart markers: ###EMAIL_TEMPLATE_SETFIXED_REVIEW### and HTML variant renamed to ###EMAIL_TEMPLATE_SETFIXED_REVIEW_ADMIN###, because it is sent to the admin and not to the user.
- fix bug 4341: delete regHash after usage and no confirmation email will be sent twice using short urls
- enhance feature: ###EMAIL_TEMPLATE_SETFIXED_ENTER_ADMIN### and HTML as notification when a user has clicked on the login link
- fix bug in order not to lose the chosen checkbox entries on create if the user steps back to the entry form.
History
Updated by Christoph Niewerth over 3 years ago
The problem with tslib_cObj as type hinting in constructor is tslib_cObj
needing a correct initialized fe to work with full potential.
Within tx_tmpl_Template tslib_cObj only function is to load content of template files.
For file loading this is the case.
So ajax-eID-controller can not use tmpl to render mails for example.
With removing type hinting from constructor and changing method loadHtmlFile,
ajax-eID-controller gain access to the template engine without loosing backwards compatibility.
The only disadvantage are view helpers using tslib_cObj without correct fe. They have a chance to fail.
That depends of what they do with tslib_cObj.
I suggest adding a comment within phpDoc and manual.
Edit:
Changed notice from german to english with little additional thoughts.