Bug #4501
error in new_post.html template
| Status: | Resolved | Start date: | 2009-09-08 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | Forum | |||
| Target version: | 1.9.0 | Estimated time: | 0.50 hour | |
| Votes: | 0 |
Description
Since you changed the template today the first part of the javascript at the top is useless (you replaced the id message).
For the second part I couldn't find a reason to be there either.
function del() {
document.getElementById('message').innerHTML = "";
}
function set_action(param) {
document.getElementById('field_text').value = param;
document.post.submit();
}
Associated revisions
Fixed bug #4501
Fixed bug #4501
git-svn-id: https://svn.typo3.org/TYPO3v4/Extensions/mm_forum/trunk@25057 735d13b6-9817-0410-8766-e36946ffe9aa
History
Updated by Martin Helmich over 3 years ago
- Status changed from New to Accepted
- Target version set to 1.9.0
- Estimated time set to 0.50
Updated by Hauke Hain over 3 years ago
- File changeID.patch added
- File removeJS.patch added
Also new_topic.html is affected.
At least it should be reduced to the following with the right id to search:
<script type="text/javascript">
function del() {
document.getElementById('tx_mmforum_editor').innerHTML = "";
}
var editor = new tx_mmforum_Editor();
</script>
I do not know what the functions set_action and del are for and especially not when the are called. I even do not know why the variable editor is needed.
I removed the whole JS from both template files and I couldn't find a difference.
Martin, do you know what they are for?
I attached two patches. One for changing the id only and one for removing the JS.
Updated by Martin Helmich over 3 years ago
Hey Hauke,
concerning the set_action and del methods, I do not have any idea what these are for, probably some legacy code from an older version. If they really are not called anywhere, I see no problem in removing them.
The editor variable however is needed for inserting BBCodes and smileys.
Martin
Updated by Hauke Hain over 3 years ago
- Status changed from Accepted to Resolved
Hi Martin,
I searched everywhere and found nothing. So I removed the JS.