CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #4892

removeXSSStripTagsArray is working wrong

Added by Michael Staatz over 3 years ago. Updated over 2 years ago.

Status:Resolved Start date:2009-10-05
Priority:Should have Due date:
Assignee:- % Done:

0%

Category:Bug Spent time: 0.51 hour
Target version:0.11.x
Votes: 0

Description

The function now returns a FALSE instead of an empty array, this will not work for some conditions.
Example

$this->MYSESSION['billing'] = 
tx_commerce_div::removeXSSStripTagsArray($GLOBALS['TSFE']->fe_user->getKey('ses', tx_commerce_div::generateSessionKey('billing')));

if you look now in

$this->MYSESSION['billing']

it has FALSE. And if you now do something like (class.tx_commerce_pi3.php -> line 1889)

... !isset($this->MYSESSION['billing'])) ...

this condition returns FALSE because the array with the key 'billing' has false... Example:
array('billing' => false)

I have attached a version of removeXSSStripTagsArray.

And there for i reopen Issue #4359 and #4525

Kind regards

Michael Staatz

new_removeXSSStripTagsArray.diff (1.1 kB) Michael Staatz, 2009-10-05 09:46


Related issues

related to commerce - Bug #4296: set payment session on change to NULL Closed 2009-08-21
related to commerce - Bug #4359: Empty delivery adress when no delivery adress is not sele... Closed 2009-08-27
related to commerce - Bug #4525: payment needAdditionalData proofs data even is MYSSESSION... Closed 2009-09-10
related to commerce - Bug #4834: Checkout possible without Billig Address Resolved 2009-09-30
related to commerce - Bug #4379: Checkout - no check if address is available Rejected 2009-08-28

Associated revisions

Revision 26465
Added by Ingo Schmitt over 3 years ago

  • Fixed issue 4892, Thanks to Michael Staatz

Revision 26465
Added by Ingo Schmitt over 3 years ago

  • Fixed issue 4892, Thanks to Michael Staatz

History

Updated by Ingo Schmitt over 3 years ago

  • Target version set to 0.11.x

Updated by Ingo Schmitt over 3 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF