Task #4899
Add check for install Too security.
| Status: | Accepted | Start date: | 2009-10-05 | ||
|---|---|---|---|---|---|
| Priority: | Should have | Due date: | |||
| Assignee: | Tobias Liebig | % Done: | 50% |
||
| Category: | Service-Layer | ||||
| Target version: | Alpha 2 | ||||
| Votes: | 0 |
Description
There should be a test to ensure that the install tool is disabled.
History
Updated by Martin Kuster over 3 years ago
- File 4899.patch added
Attached a patch that implements that.
We have it implemented as a part of our set of services for all security related checks.
Updated by Tobias Liebig over 3 years ago
- Status changed from New to Accepted
- Assignee set to Tobias Liebig
nice work. i will review this in the next days
Updated by Martin Kuster over 3 years ago
- File 4899v2.patch added
Attached patch adds also the other security test services.
Updated by Martin Kuster over 3 years ago
- File 4899v3.patch added
And with tests for each service and the operation.
Updated by Tobias Liebig over 3 years ago
Sorry for beeing that late with the review.
I really like your idea and i think the caretaker should really ship with such test services.
We like to have only very simple, generic, atomic operations, which can be reused for other test services.
All logic should be implemented in the test service (instaed of the operation).
So i think we need two new operations:
- tx_caretakerinstance_Operation_*FileExists*
- expects a filename as parameter and
- return true or false
- tx_caretakerinstance_Operation_*MatchConfVar*
- expects something like
- "TYPO3_CONF_VARS|BE|installToolPassword"
- and a expected value
- returns true if value matches the requested TYPO3_CONF_VARS or false if it doesnt
- expects something like
- the "isDefaultAdminAccountPresent" method can be solved by using the Operation "tx_caretakerinstance_Operation_GetRecord"
The evaluation will happen in the test service.
Updated by Tobias Liebig 7 months ago
- % Done changed from 0 to 50
As we already have the two missing operations (CheckPathExists & MatchPredefinedVariable) it should be easy now to implement a testService using these operations.