Project

General

Profile

Actions
Copy link

Feature #49822

closed

Allow to disable the 4th part of the typolink generation

Added by Ercüment Topal almost 11 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-07-09
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Hey guys,

i worked with the typolink generation and add a 5th param to the link configuration field. The current problem is, that the 4th param can not be disabled in the typolink function.

The patch attached fix this issue by a simple check against "-" (like the params 1-3).
TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->typolink

It is a smart solution to add/allow custom link configuration parameters?

Regards,
Ercüment

Files

add_diable_option_for_the_4th_link_parameter.patch (940 Bytes) add_diable_option_for_the_4th_link_parameter.patch Ercüment Topal, 2013-07-09 14:44
Actions
Copy link
 #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22160

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22160

Actions
Copy link
 #3

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22160

Actions
Copy link
 #4

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22160

Actions
Copy link
 #5

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22160

Actions
Copy link
 #6

Updated by Stefan Neufeind about 9 years ago

  • Tracker changed from Bug to Feature
Actions
Copy link
 #7

Updated by Gerrit Code Review about 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/22160

Actions
Copy link
 #8

Updated by Stefan Neufeind almost 9 years ago

In general: This still applies to master (CMS 7) at the moment, but lives in the TypoLinkCodecService now. Decision is still open however how we want to handle it.

Actions
Copy link
 #9

Updated by Tim Lochmüller almost 9 years ago

We do not need this patch anymore. In the current master, the TypoLinkCodecService check the 4. param against static::$emptyValueSymbol ("-"). So the patch is not needed anymore...

Please close the issue!!!

Actions
Copy link
 #10

Updated by Georg Ringer almost 9 years ago

  • Status changed from Under Review to Closed
Actions
Copy link

Also available in: Atom PDF