Bug #5005
cli occures php error if "-s" option is given
| Status: | Resolved | Start date: | 2009-10-16 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Martin Ficzel | % Done: | 100% |
|
| Category: | CLI | |||
| Target version: | Alpha 1 | |||
| Votes: | 0 |
Description
if you call the cli command e.g. to update the extension list and add the "-s" or "-ss" option (silence) to supress the output, it fails with an php error
/home/caretaker_networkteam/htdocs/typo3/cli_dispatch.phpsh caretaker update-extension-list -s Fatal error: Call to private method tx_caretaker_CliLogger::setSilentMode() from context 'tx_caretaker_Cli' in /home/caretaker_networkteam/htdocs/typo3conf/ext/caretaker/classes/class.tx_caretaker_Cli.php on line 100
Associated revisions
Changed scope of SetSilentMode Method of CLI-Logger to public. Fixes #5005
History
Updated by Tobias Liebig over 3 years ago
- Status changed from Accepted to New
- Assignee changed from Tobias Liebig to Martin Ficzel
- Priority changed from Should have to Must have
- % Done changed from 0 to 50
the method definition of setSilentMode changed from "public" to "private" in r20413
- we should never use "private", but "protected" instead, as you can't override private methodes using inheritance
- nevertheless setSilentMode should be public, so it can be called form out side (which makes sense for setters)
Martin: as you commited r20413, can you please double check your changes?
Updated by Martin Ficzel over 3 years ago
- Status changed from New to Resolved
- % Done changed from 50 to 100
Applied in changeset r25458.