Project

General

Profile

Actions

Task #50473

closed

Template Analyzer processes includes twice

Added by Francois Suter over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Miscellaneous
Target version:
Start date:
2013-07-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The Template Analyzer BE module parses the TypoScript inclusions twice.

In \TYPO3\CMS\TsTemplate\Controller\TemplateAnalyzerModuleFunctionController::initialize_editor(), \TYPO3\CMS\Core\TypoScript\TemplateService::runThroughTemplates() is called. At the end of this method \TYPO3\CMS\Core\TypoScript\TemplateService::processIncludes() is called.

Later \TYPO3\CMS\TsTemplate\Controller\TemplateAnalyzerModuleFunctionController::main() directly calls \TYPO3\CMS\Core\TypoScript\TemplateService::processIncludes(), which is unnecessary.

This is just a cleanup which I propose to do only for current master.

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22612

Actions #2

Updated by Francois Suter over 10 years ago

Testing is dead simple:

  • check your templates in the Template Analyzer
  • apply the patch
  • check again, nothing should have changed.
Actions #3

Updated by Francois Suter over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF