Bug #51042
closed
Update Video JS to use it in current browsers
0%
Description
Video JS is very outdated in TYPO3 (tested 4.7 and 6.1, both have an old version), it is version 2.0.3, current is 4.1.0. The included version does not work at all in current browsers, so please update the library. When the library is updated, class.tslib_content_flowplayer.php must be modified a little to get it work. In the video tag there should be data-setup="{}", otherwise it doesn’t work. I have modified class.tslib_content_flowplayer.php on a 4.7.12 installation in order to get to work:
- HTML5 video with current video js
- Poster image for video (was only implemented when using Flashplayer)
- HTML5 audio with mediaelement.js
If somebody is interested and it helps to integrate it, I will share the file of course.
Files
Updated by Philipp Gampe over 10 years ago
- Priority changed from Should have to Could have
- Complexity set to hard
Did you test with the latest versions of TYPO3 CMS?
Is the change fully backward compatible (required for inclusion in TYPO3 CMS 4.7 branch)?
Please attach a diff (or your modified files) here. Or you can speed things up by pushing a patch to gerrit: http://wiki.typo3.org/CWT
Updated by Philipp Gampe over 10 years ago
- Status changed from New to Needs Feedback
- Complexity changed from hard to medium
Updated by Bernhard Eckl over 10 years ago
- File class.tslib_content_flowplayer.patch class.tslib_content_flowplayer.patch added
- File class.tslib_content_flowplayer-mod.php class.tslib_content_flowplayer-mod.php added
- File class.tslib_content_flowplayer-org.php class.tslib_content_flowplayer-org.php added
Sorry for my late. I attached a patch file, the modified file and the original file. But it is from 4.7, in 6.x the file is typo3/sysext/frontend/Classes/ContentObject/FlowPlayerContentObject.php (very similar, a few class name changes). It contains the changes (see related issues):
- to work with the latest VideoJS version
- get the .jpg file and use as a poster image
- let audio work with mediaelement.js
Some lines which are not needed anymore I just commented instead of deleting them. There may be some other things which are not needed anymore and should be cleaned up (by a core member who knows it better). Maybe this could be integrated into the upcoming 6.2 release? It would be great to have an LTS version where the media element is usable with HTML5.
Updated by Ernesto Baschny over 10 years ago
- Category set to 1050
- Is Regression set to No
We could also decide to move away from VideoJS and instead move over to https://github.com/johndyer/mediaelement in newer TYPO3 versions (i.e. 6.2).
But then again some year later this gets obsolete again.
What we first would need is an stable API so that extensions could hook into the video / audio rendering of the frontend in a unified way. Then we provide "videojs" and maybe "mediaelement" with the core for "out-of-the-box" experience, but which could be disabled and replaced by some more modern variant in future (coming from TER).
I would rather concentrate on that for 6.2 and let 4.7+6.0+6.1 stay as they are as this seems to me a waste of resources.
What do you think?
Updated by Bernhard Eckl over 10 years ago
I think there should be an out of the box solution which works without messing around the core files (like I did). An API for extensions is not bad, but it should not be the only way to get it work (I am not a fan of using x extensions for simple tasks which also can be done by the core, that’s why I edited the core filed to get it work and report it here with the hope that sometime it will work without hacking around the code). If somebody wants to customize it or do something else (like another video player), it should be possible to do it via typoscript (this is the main advantage of TYPO3). To just concentrate on 6.2 and save resources to get a working solution is a good idea. But it should be updateable (existing content elements could have a different flexform xml). I hope there will be a solution before 6.2 releases, there is not so much time anymore.
Updated by Bernhard Eckl over 10 years ago
- File FlowPlayerContentObject.php FlowPlayerContentObject.php added
- File FlowPlayerContentObject.patch FlowPlayerContentObject.patch added
Here is the file with the same modifications from 6.1.3 and the patch file.
Updated by Alexander Opitz over 10 years ago
- Status changed from Needs Feedback to New
Updated by Björn Jacob over 9 years ago
When do we get this feature? I highly want to see the poster attribute coming :)
Updated by Riccardo De Contardi almost 9 years ago
As far as I have understood, looking at #48223 there is mainly a license problem :S
Updated by Bernhard Eckl almost 9 years ago
A button in the install tool to download video js? Many Linux distributions do this similar, e.g. for MP3 Support. Or a separate extension to handle this?
Updated by Georg Ringer over 8 years ago
- Status changed from New to Closed
there is no flowplayer or video js anymore in the core with CMS 7, therefore I close this. nothing will be changed for 6.2
Updated by Oliver Hader over 6 years ago
- Category changed from 1050 to Frontend