Task #51512: Unreadable directories cause exceptions - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #51512

closed

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54267: As an Editor I want to use a FAL withouth bugs

Unreadable directories cause exceptions

Added by Bernhard Kraft over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Steffen Ritter

Category:

File Abstraction Layer (FAL)

Target version:

6.2.0

Start date:

2013-08-29

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

medium

Sprint Focus:

Description

If there is an unreadable file in the fileadmin directory the tree and listing frame of fileadmin throw execptions which make the fileadmin unusable.

reproducing the error:

mkdir -p fileadmin/testDirectory/someDirectory
chown root:root fileadmin/testDirectory/someDirectory
chmod 600 fileadmin/testDirectory/someDirectory

Browse to "testDirectory" and the issues begin ...

Normally all directoreis in "fileadmin" should be readable but in the case of a network mounted directory (Windows share, SMB/CIFS, NFS, cloud storage, etc.) it could be that parts of the fileadmin directory are unreadable and that this can not get changed by the webadmin.

I am working on a patch.

Files

patch_51512.diff (1019 Bytes) patch_51512.diff

Bernhard Kraft, 2013-08-29 14:29

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Philipp Gampe over 10 years ago

Category changed from Backend User Interface to File Abstraction Layer (FAL)
Status changed from New to Accepted
Assignee set to Bernhard Kraft
Complexity set to medium

Actions

Copy link

Updated by Bernhard Kraft over 10 years ago

File patch_51512.diff patch_51512.diff added

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23460

Actions

Copy link

Updated by Bernhard Kraft over 10 years ago

Status changed from Under Review to Accepted

https://review.typo3.org/#/c/23460/

Actions

Copy link

Updated by Bernhard Kraft over 10 years ago

The question is:

Should the drivers of a FAL storage throw execptions in the case of an error and those exceptions should get handled by the Repository/Storage.

Or should a driver never throw an exception but catch them on the public methods available to the Storage and simply return NULL value results or empty arrays in such a case.

Actions

Copy link

Updated by Andreas Wolf over 10 years ago

Is Regression set to No

Catching exceptions is the responsibility of the UI/control logic, because it knows best how to deal with them - display a message, discard them or just let the whole operation fail. Driver exceptions could be wrapped by the Storage, to have unified exceptions, but that's not strictly necessary if we limit the types of exceptions that drivers might throw for certain operations.

Actions

Copy link

Updated by Steffen Ritter over 10 years ago

Assignee changed from Bernhard Kraft to Steffen Ritter

Actions

Copy link

Updated by Steffen Ritter over 10 years ago

Parent task set to #54267

Actions

Copy link

Updated by Gerrit Code Review over 10 years ago

Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

Actions

Copy link

#10

Updated by Steffen Ritter over 10 years ago

% Done changed from 0 to 50

Actions

Copy link

#11

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

Actions

Copy link

#12

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

Actions

Copy link

#13

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26905

Actions

Copy link

#14