Project

General

Profile

Actions

Task #54286

closed

ClickMenu: Set background via CSS instead of JS

Added by Stefan Neufeind over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2013-12-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently the ClickMenu-rows change their background-color via JS:

onmouseover="this.bgColor='#dedede';" onmouseout="this.bgColor='';"

This could/should be done via CSS, making the necessary HTML smaller, saving JS-performance and keeping the styling in a central place (CSS).

Actions #1

Updated by Stefan Neufeind over 10 years ago

Relevant places in source:

typo3/sysext/t3skin/Resources/Public/Css/visual/element_csm.css
15:table.typo3-CSM tr.typo3-CSM-itemRow {

typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php
1192: <tr class="typo3-CSM-itemRow" onclick="' . htmlspecialchars($onClick) . '" onmouseover="this.bgColor=\'' . $GLOBALS['TBE_TEMPLATE']->bgColor5 . '\';" onmouseout="this.bgColor=\'\';"' . $CSM . '>

Actions #2

Updated by Stefan Neufeind over 10 years ago

Currently the color-values are set in $GLOBALS['TBE_STYLES'] and are afaik not yet available via CSS. So for the moment they can't be used with CSS-classes or so.

As a general solution for the hovering in ClickMenu I see the using of CSS-hover-states. But to be able to add colors in a central place in the CSS maybe we'd need to use SASS or the like then.

Actions #3

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26092

Actions #4

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26092

Actions #5

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26092

Actions #6

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26092

Actions #7

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26092

Actions #8

Updated by Stefan Neufeind about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF