Project

General

Profile

Actions

Feature #54513

closed

linkvalidator: improve tolerance for forbidden HEAD requests

Added by Alexander Stehlik over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2013-12-19
Due date:
% Done:

100%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

Currently the linkhandler will first try a HEAD request to check an external link.

If the server returns the correct response code (405 - Method not allowed) it will retry the request using the GET method.

Unfortunately I stumbled over some misconfigured servers that will return 403 - Forbidden response codes when the HEAD method is used. In that case the linkvalidator will report a broken link, even though the GET request would work fine.

Of course it would be nice if all servers are configured correctly but there probably will always be some that are not.

So my suggestion is to also retry the GET request on 403 errors or alternatively make the response codes configurable that trigger a fallback GET request.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #58145: Linkvalidator - HEAD response codesClosed2014-04-24

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

Actions #3

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

Actions #4

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

Actions #5

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26489

Actions #6

Updated by Alexander Stehlik about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF