Project

General

Profile

Actions
Copy link

Task #54856

closed

Optimize TypoScriptParser

Added by Michiel Roos over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
6.2.0
Start date:
2014-01-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Sprint Focus:

Description

The code in \TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser gets called a lot. It needs to be optimised.

Problems:
  • Usage of inefficient function calls where language constructs would do the job
  • No dedicated Frontend parsing path. All the highlighting and linenumbering ifs are checked over and over for each layer of TypoScript that is being parsed
  • The amount of function calls can be greatly reduced

For the Introduction package, a page hit that is not yet in TYPO3 cache:

Number of Function Calls
before:    135.185
after:     111.251
reduction: -23.934 Or -17,7%

Incl. Wall Time
before:      6,31 s
after:       1,22 s
reduction:  -5,09 s Or -80,6%

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #55357: TS Parser: Fix regression when having tabs in TS namesClosedBenni Mack2014-01-27

Actions
Related to TYPO3 Core - Bug #62188: TypoScriptParser doesn't trim modificator anymoreClosedStefan Froemken2014-10-13

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #3

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #4

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #5

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #6

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #7

Updated by Gerrit Code Review over 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #8

Updated by Gerrit Code Review over 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #9

Updated by Gerrit Code Review over 10 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #10

Updated by Gerrit Code Review over 10 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #11

Updated by Gerrit Code Review over 10 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #12

Updated by Gerrit Code Review over 10 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #13

Updated by Gerrit Code Review over 10 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #14

Updated by Gerrit Code Review over 10 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #15

Updated by Gerrit Code Review over 10 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #16

Updated by Gerrit Code Review over 10 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #17

Updated by Gerrit Code Review over 10 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #18

Updated by Gerrit Code Review over 10 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #19

Updated by Gerrit Code Review over 10 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #20

Updated by Gerrit Code Review over 10 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26701

Actions
Copy link
 #21

Updated by Michiel Roos about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #22

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF