Project

General

Profile

Actions

Task #55122

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Story #55078: Optimize PHP code performance in TYPO3 methods

Cleanup and optimize methods in ExtensionManagementUtility

Added by Michiel Roos over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Performance
Target version:
Start date:
2014-01-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
medium
Sprint Focus:

Description

Methods in ExtenstionManagementUtility are called a lot. We need to ensure they are as performant as possible.

  • Reduce function calls
  • Use language constructs instead of functions
  • Use language constructs to check values before calling a function
  • Return early where possible
  • Rewrite addToAllTCAtypes() to just do a few preg_replace() calls and not call all the child methods

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #55662: PHP Warning preg_replace in current masterClosed2014-02-04

Actions
Actions #1

Updated by Michiel Roos over 10 years ago

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::executePositionedStringInsertion()
http://pastebin.com/UbMrdUL4

Actions #3

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #4

Updated by Ernesto Baschny over 10 years ago

  • Parent task set to #55078
Actions #5

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #6

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #7

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #9

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27019

Actions #10

Updated by Michiel Roos over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF