Bug #5514

"Update content" label is misleading if content has not actually been saved or changed

Added by Steffen Miebach over 3 years ago. Updated over 2 years ago.

Status:Accepted Start date:2009-11-26
Priority:Should have Due date:
Assignee:Jeff Segars % Done:

0%
Category:-
Target version:1.6.0
Votes: 0

Description

If I create a new Text-Object and deactivate the Rich-Text-Editor and close the form without saving (with the close-button), nevertheless the text will be saved.

The same happens if I turn off the RTE in the form, write some text and activate it afterwards again. If I close the window without saving, the text will be saved.

If I do not deactivate the RTE, the close-button works correctly and the content is not been saved after closing the window.

I used 1.1.0, Firefox, RC2 + TV

Related issues

duplicated by Advanced Frontend Editing - Bug #9243: Button close save modification ! Rejected 2010-08-11

History

#1
Updated by Chris topher over 3 years ago

And one note: When you click on "Close", you get a message saying "Updating content".
This message is also shown, when the RTE is activated.

It should instead say something like "Closing Editing Form".

#2
Updated by Jeff Segars over 3 years ago

  • Status changed from New to Needs Feedback
  • Target version changed from 1.1.0 to 1.2.0

Is anyone able to confirm that the content is actually saved when the close button is pressed or is it just a misleading label that we're dealing with? From my testing, it looks like a label issue only.

#3
Updated by Chris topher over 3 years ago

Jeff Segars wrote:

Is anyone able to confirm that the content is actually saved when the close button is pressed or is it just a misleading label that we're dealing with? From my testing, it looks like a label issue only.

Right.

Checking this without TemplaVoila: The content is not saved; no matter if with or without RTE.

It is just the misleading label.

#4
Updated by Jeff Segars over 3 years ago

  • Subject changed from Close-Button saves content anyway if RTE is disabled to "Update content" label is misleading if content has not actually been saved or changed
  • Status changed from Needs Feedback to Accepted
  • Assignee set to Jeff Segars
  • Target version changed from 1.2.0 to 1.3.0

#5
Updated by Chris topher over 3 years ago

Such notice is also shown, if you close the window "edit page properties" (without saving).
There it should be fixed, too.

#6
Updated by Jeff Segars about 3 years ago

  • Target version changed from 1.3.0 to 1.4.0

#7
Updated by Jeff Segars almost 3 years ago

  • Target version changed from 1.4.0 to 1.6.0

I've got a patch in progress, but its more complicated than it would seem for just a label since the editing happens in an iframe and its not immediately clear whether it has changed or not.

#8
Updated by Chris topher over 2 years ago

Jeff, I don't know how much you have already done for this patch.
But if it was not too much, I would say we should simply fix the label to say something like "Closing Editing Form", which fits in all cases.

What do you think?

Also available in: Atom PDF