Task #55445: Use array access instead of strpos($str, n, 1) - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #55445

closed

Use array access instead of strpos($str, n, 1)

Added by Michiel Roos about 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

6.2.0

Start date:

2014-01-29

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

A call to strpos can be avoided in case the 'count' parameter is 1.

Use:
$str{n}

Instead of:
strpos($str, n, 1)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Michiel Roos about 10 years ago

Oops, I wrote strpos instead of substr . . . please correct.

Actions

Copy link

Updated by Michiel Roos about 10 years ago

Reduces call count to substr by 4.289 calls for a page like: http://6.2.master.workbench.local/examples/images-with-links/. From the introduction package.

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27136

Actions

Copy link

#10