Project

General

Profile

Actions
Copy link

Bug #55510

closed

Selects have a ugly padding

Added by Stephan Großberndt about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2014-01-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Bugfix #55319 "Buttons" sets padding and margin for all selects:

.t3-button, input, textarea, select, button {
  padding: 3px 6px;
  margin: 0 0.5em 0.5em 0;
}

This is a new rule and looks ugly.

Files

Download all files
select-padding.png (3.75 KB) select-padding.png Stephan Großberndt, 2014-01-31 13:39
select-padding2.png (5.65 KB) select-padding2.png Stephan Großberndt, 2014-01-31 13:50
Bildschirmfoto_2014-02-03_um_12.12.38.png (16.1 KB) Bildschirmfoto_2014-02-03_um_12.12.38.png Felix Kopp, 2014-02-03 12:14

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #55319: ButtonsClosed2014-02-01

Actions
Related to TYPO3 Core - Bug #56120: Unify form fields: SELECTClosedFelix Kopp2014-02-19

Actions
Actions
Copy link
 #2

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190

Actions
Copy link
 #3

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190

Actions
Copy link
 #4

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27190

Actions
Copy link
 #5

Updated by Stephan Großberndt about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Mathias Brodala about 10 years ago

Just as a note: this could have actually improved usability quite a bit since the hit area for the select was larger.

"Ugly" is a rather subjective justification for removing this.

Actions
Copy link
 #7

Updated by Felix Kopp about 10 years ago

Also now the select fields are not of the equal height of input fields & submit/buttons.
I included the padding to gain similar sizes for all form elements.

What exactely is the reason to remove the padding besides the white background?

Actions
Copy link
 #9

Updated by Stephan Großberndt about 10 years ago

The reason is e.g. selects in typo3-docheader:

The select is too high for it due to the (new introduced) padding.

The dropdown-indicator does not look good in all browsers. Some do not move the dropdown-indicator to the right. A possible solution for that might be using something like http://cssdeck.com/labs/styling-select-box-with-css3

Actions
Copy link
 #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF