CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.6 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #6074

Option "override url path" with full URL like http://www.domain.tld/

Added by Fabian Constien over 3 years ago. Updated over 2 years ago.

Status:New Start date:2010-01-18
Priority:-- undefined -- Due date:
Assignee:Tolleiv Nietsch % Done:

0%

Category:-
Target version:-
Votes: 0

Description

Hello,

I use Typo3 4.3.1 with realurl 1.7.0 and aoe_realurlpath 0.1.16.

I set the option "override url path" with http://www.domain.tld/ and it works fine.

Today I tested aoe_realurlpath 0.3.4, because I have sometimes problems with wrong rootpids and I would like to see if 0.3.4 works better.

But with version 0.3.4 the option "override url path" does not work anymore with http://www.domain.tld/, the URL goes to http://www.domain.tld/http/www-domain-tld/, so the value of this option is destroyed (http://www.domain.tld/ >> http/www-domain-tld/).

Is this a bug or is there a trick to use this option in my way again?

Kind regards

Fabian

History

Updated by Tolleiv Nietsch over 3 years ago

probably a bug - there's no full support for realurl 1.7.0 yet

Updated by Fabian Constien over 3 years ago

Today I tested aoe_realurlpath 0.3.4 with realurl 1.6.0 and the option "override url path" does not work anymore too.

http://www.domain.tld/ >> http/www-domain-tld/

So I think aoe_realurlpath does modify the value at "override url path" in my situation.

Updated by Fabian Constien over 3 years ago

  • Assignee set to Tolleiv Nietsch

This night I tried a lot of different revisions.

Result:
Rev. 21837 = OK (option "override url path": http://www.domain.tld/ >> http://www.domain.tld/)
Rev. 21838 = NOT OK (option "override url path": http://www.domain.tld/ >> http/www-domain-tld/)

Difference between these revisions: http://forge.typo3.org/issues/show/3780

@Tolleiv:
Could it be possible, that there is a problem/ bug of using the option "override url path" in my way since rev. 21838? I think imho so...

Updated by Tolleiv Nietsch over 3 years ago

Hi,

thanks for traking that down - actually AOE is currently using a patched version of RealURL and therefore this didn't show up...

I couldn't check that deeper, but I think that this line "unset($params['paramKeyValues']['id']);" in /aoe_realurl/trunk/class.tx_aoerealurlpath_pagepath.php might cause your problems because RealURL relies on that later on.

Not sure if just leaving that in place will help - since we removed it for a purpose ... within RealURL you could check the places where this is needed and check whether they still work as supposed. We're working on a better integration with RealURL but sometimes it's hard to convince Dmitry to make small adjustments on his API.

Hope that helped,
Cheers

Updated by Fabian Constien about 3 years ago

Hi,

the following change fix this issue in my opinion. If you see no problems, it would be nice if you could integrate this change in your code.

file: class.tx_aoerealurlpath_pathgenerator.php

} elseif ($overridePath = $this->_stripSlashes ( $lastPage ['tx_aoerealurlpath_overridepath'] )) {
    $parts = explode ( '/', $overridePath );
    $cleanParts = array_map ( array (
        $this,
        'encodeTitle'
    ), $parts );
    $nonEmptyParts = array_filter ( $cleanParts );
    $pathString = implode ( '/', $nonEmptyParts );
}

change to

} elseif ($overridePath = $this->_stripSlashes ( $lastPage ['tx_aoerealurlpath_overridepath'] )) {
    if (! preg_match ( '/^http:\/\//', $overridePath )) {
        $parts = explode ( '/', $overridePath );
        $cleanParts = array_map ( array (
            $this,
            'encodeTitle'
        ), $parts );
        $nonEmptyParts = array_filter ( $cleanParts );
        $pathString = implode ( '/', $nonEmptyParts );
    } else {
        $pathString = $overridePath;
    }
}

Thanks in advance.

Fabian

Also available in: Atom PDF