Bug #64165
closed
Mixed up configuration options of the Abbreviation RTE plugin
100%
Description
As far as I understand it there seems to be a mixup of configuration options in the abbreviation / acronym plugin of the rtehtmlarea RTE.
In the Abbreviation.js file there options are currently used:
this.pageTSConfiguration.noAcronym this.pageTSConfiguration.noAbbr
As far as I understand it, these option should disable the acronym / abbreviation tabs. So when both are set to FALSE, the button is not available. Makes sense.
What does not make sense is that these options are also used to determine if there are predefined acronyms or abbreviations.
The main error is that the values are overwritten in the buildJavascriptConfiguration() method of the Abbreviation PHP Plugin class.
Another error is that these settings are used to determine, if the fieldsets with the predefined values should be rendered. This should be totally independent configuration options IMO.
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35863
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35863
Updated by Stanislas Rolland over 9 years ago
- Description updated (diff)
This is a duplicate of #63040 with a different solution.
Properties noAbbr and noAcronym should only be used to determine whether the predefined abbreviations or predefined acronyms fieldsets should be shown as they indicate that such predefined items exist or not.
Property removeAcronymTab is missing to specify that the Acronym tab should not be shown.
As the acronym tag is deprecated, this is the only property really needed. It would not make much sense to remove the abbreviation tab.
Please review and test this change: http://review.typo3.org/34287
Updated by Alexander Stehlik over 9 years ago
Thank you for the pointer :)
I'll have a look at it when Gerrit is back online.
Updated by Stanislas Rolland over 9 years ago
I think that the plugin works as intended: if no records are found, the button is disabled, if no records of one of the two types is found, the corresponding tab is removed.
Updated by Alexander Stehlik over 9 years ago
You could still set manual abbreviations / acronyms, right?
IMO this is a bug. Only the select fields should be hidden if no records are found.
The tabs and the button should never disappear because no records exist.
Can you explain why the buttons / tabs should be hidden?
Updated by Stanislas Rolland over 9 years ago
Alexander Stehlik wrote:
You could still set manual abbreviations / acronyms, right?
IMO this is a bug. Only the select fields should be hidden if no records are found.
The tabs and the button should never disappear because no records exist.
Can you explain why the buttons / tabs should be hidden?
I agree with you, this is an historical bug. And it should be fixed on TYPO3 CMS 7.
But I am concerned that if we fix this in 6.2, the user will have no way to remove the acronym tab. And some installations may see it suddenly appear... Perhaps we could keep the abbreviation tab if no abbreviation record exists.
Updated by Stanislas Rolland over 9 years ago
There is another bug in the handling of the fieldsets of this plugin. If no text is currently selected, the ad hoc abbreviation/acronym fieldsets should not be available because this causes an empty tag to be inserted.
Updated by Alexander Stehlik over 9 years ago
I see, thanks for your explanations.
I guess this issue can be closed an we should concentrate on cleaning this up in https://review.typo3.org/#/c/34287/ :)
Updated by Stanislas Rolland over 9 years ago
- Status changed from Under Review to Closed
Updated by Gerrit Code Review over 9 years ago
- Status changed from Closed to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34287
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34287
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36725
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/34287
Updated by Stanislas Rolland over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5a75836275db42fbc4bc3e5854c059451fde7547.
Updated by