Bug #67013: felogin setting plugin.tx_felogin_pi1.redirectMode = refererDomains causes an exception - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #67013

closed

felogin setting plugin.tx_felogin_pi1.redirectMode = refererDomains causes an exception

Added by Mike Wanush almost 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

felogin

Target version:

6.2.13

Start date:

2015-05-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.5

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

Line 692 (of the current git version) uses the following regular expression:

if (preg_match('/(^|\\.)/' . $d . '$', $redirect_domain)) {

As $d in this case is a domain string, it causes an exception:

#1: PHP Warning: preg_match(): Unknown modifier 'w' in ...

The line should be changed to

if (preg_match('/(^|\\.)' . $d . '$/', $redirect_domain)) {

See attached felogin.patch.

Files

felogin.patch (518 Bytes) felogin.patch

Mike Wanush, 2015-05-18 18:43

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Markus Klein almost 9 years ago

Can you please describe the full usecase?

Actions

Copy link

Updated by Markus Klein almost 9 years ago

Status changed from New to Accepted
Target version set to 6.2.13

Had a quick look, you're right of course.

Can you push the patch to our review system?

Actions

Copy link

Updated by Markus Klein almost 9 years ago

Funny, this traces back to 2009: #19728

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39601

Actions

Copy link

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39601

Actions

Copy link