Bug #6979
betweenValue checks for float
| Status: | Resolved | Start date: | 2010-03-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Reinhard Führicht | % Done: | 100% |
|
| Category: | Validator | |||
| Target version: | Stable v1.0 | |||
| Votes: | 0 |
Description
As far as i see betweenValue checks for a valid integer. Float numbers (, or . separated) cause an error, but this sould be done by error check "integer". It should be possible to check values between float numbers.
I think line 39
(!t3lib_div::testInt($gp[$name]) ||should be removed in file Tx_Formhandler_ErrorCheck_BetweenValue.php.
History
Updated by Reinhard Führicht about 3 years ago
- Status changed from New to Accepted
- Assignee set to Reinhard Führicht
I think the whole condition needs an update to suit your needs. I will look into it. Should be ready next week.
Updated by Reinhard Führicht about 3 years ago
- Target version set to Beta 5 (v0.9.8)
Updated by Felix Nagel about 3 years ago
No actually need. I only noticed this does not work as expected.
Updated by Reinhard Führicht almost 3 years ago
- File 6979.patch added
- Status changed from Accepted to Needs Feedback
Finally, I found time to deal with this one.
Please have a look at the attached patch.
It can deal with float values separated by "." or ",".
Updated by Reinhard Führicht almost 3 years ago
- Target version changed from Beta 5 (v0.9.8) to Beta 6 (v0.9.9)
Updated by Reinhard Führicht over 2 years ago
Reminder #1.
Felix, is this patch OK for you?
Updated by Felix Nagel over 2 years ago
Sorry, Ive got no useful testcase for this and minimal time atm.
No actually need. I only noticed this does not work as expected.
Updated by Reinhard Führicht over 2 years ago
- Target version changed from Beta 6 (v0.9.9) to Stable v1.0
Updated by Reinhard Führicht over 2 years ago
- Status changed from Needs Feedback to Resolved
- % Done changed from 0 to 100
I needed this myself now.
Committed to trunk.