Project

General

Profile

Actions

Bug #69875

closed

custom named enablecolumns for starttime and enttime don't work

Added by Philipp Schlosser over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-09-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In TypoScriptFrontendController:

The function getFirstTimeValueForRecord() builds a query like this:
SELECT MIN (' . $timeField . ') AS ' . $field ...

- $field is either 'starttime' or 'endtime'
- $timeField are the names of the model's enablecolumns

Later we try to get the $result by checking $row[$timeField]

So if there are custom names for the enablecolumns, for example 'visible_from' and 'visible_to', the $row[$timeField] is empty all the time.
Because of the 'AS' statement we could only access the array $row by the key 'starttime' or 'endtime', but with $row[$timeField] we try to access $row by the key 'visible_from' or 'visible_to'.

This issue could be fixed by changing $row[$timeField] to $row[$field].

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43488

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43488

Actions #3

Updated by Georg Ringer over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43512

Actions #5

Updated by Georg Ringer over 8 years ago

  • Status changed from Under Review to Resolved
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF