mm_forum

Hauke Hain wrote:

I have no clue what you are talking about. Please have a look at the updated manual for problems with JavaScript (Have a look at the end of chapter Getting started (introduction) for more information.

Where manual you mean? If it here http://typo3.org/documentation/document-library/extension-manuals/mm_forum/1.9.0/view/1/1/#id2550386 then no one word about syntax highlighting it present.

The headlines are: “How to include the static templates” & “Static templates: Prototype or jQuery”)

Included "Static templates: Prototype".

Will see for example "HTML" higlight. Open mm_forum config into that page and try select source code into last column. You can select only "html4strict" and if then you save and try insert that block you get code [html4strict]text[/html4strict]. Next try save and you see incorrect block into final text. Correct block you can get only for code [html]text[/html], but that source don't avaible into collumn "Source code" of config. Like problem allowed for some other source codes. I has fixed that problem only manual editing column "lang_code" of table "t3_oscada.tx_mmforum_syntaxhl" of typo3 DB.

I mean the updated manual: http://forge.typo3.org/projects/extension-mm_forum/repository/revisions/34259/entry/trunk/mm_forum/doc/manual.sxw

I think I have a clue what you mean. Hopefully anybody can reproduce and fix this error.

I think, he is talking about the codes, which are inserted after clicking the buttons.
If you e.g. click "TS" then it builds [typoscript][/typoscript]. But the config for the replacement expects [ts][/ts].
The easy fix would be to change the config within the backend module in tools -> Syntax Highlighting.

Which is the string we want to use? [typoscript] or [ts]?

Ines Willenbrock wrote:

Which is the string we want to use? [typoscript] or [ts]?

For now I use: [ts], [html] and [js].

Which are the working ones, yes.

I assume, that they are the ones, that should be used in future versions? Martin do you agree?

regards - Ines

With regards to the bug mentioned by Peter, we should fix the static data accordingly, that the longer strings are accepted for syntax highlighting.

Is it possible, to have both strings for backward compatibility?

regards - Ines

If we want to have highlighting for the longer form, we should change ext_tables_static+adt.sql to contain something like this:

INSERT INTO tx_mmforum_syntaxhl (uid, pid, tstamp, crdate, deleted, hidden, lang_title, lang_pattern, lang_code, fe_inserticon) VALUES (2, 0, UNIX_TIMESTAMP(), UNIX_TIMESTAMP(), 0, 0, 'Typoscript' , '/\\[typoscript\\](.*?)\\[\\/typoscripts\\]/isS' , 'typoscript' , 'ts.gif');

It seems impossible to have both forms without some ugly hacks.

If there are no objections, I'd attach a patch to this bug for review.

regards - Ines

Just adding a second entry for the [typoscript] tag is not as easy, as for some reason there is a UNIQUE KEY on the lang_code column of the regarding database table.
Instead of removing this unique-key, I would suggest modifying the regular expression to match both [ts] and [typoscript] (untested):

/\[(ts|typoscript)\](.*?)\[\/\\1\]/isS