Project

General

Profile

Actions

Bug #76097

closed

FormEngine: group/db broken if select contains optgroup

Added by Andreas Kienast almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Start date:
2016-05-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

The select box rendered by group/db only contains option tags by default. However, if the hook ['t3lib/class.t3lib_tceforms.php']['dbFileIcons'] manipulates the $selector (the generated HTML code of the select tag) and renders optgroups, all stored elements get removed, if new values are added to that field.

The issue is that the JavaScript gets all options by using $select.children('option'), causing all values in optgroup getting removed.


Files

dbicons_optgroup.zip (47.8 KB) dbicons_optgroup.zip Andreas Kienast, 2016-05-17 10:18
Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48044

Actions #2

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48044

Actions #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48044

Actions #4

Updated by Andreas Kienast almost 8 years ago

I've attached a test extension to test the patch. This extension requires "styleguide". The extension manipulates the field "group_db_1" found in "Form engine elements - group" and adds optgroups.

Actions #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48209

Actions #6

Updated by Andreas Fernandez almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF