CoreCommunity ExtensionsIncubatorDistributionsTYPO3 4.5 ProjectsTYPO3 4.7 ProjectsTYPO3 6.0 ProjectsTYPO3 6.1 ProjectsTYPO3 6.2 Projects (+)

Bug #7652

Wrong template loaded for new post form

Added by Nils Blattner about 3 years ago. Updated over 2 years ago.

Status:Resolved Start date:2010-05-05
Priority:Must have Due date:2010-09-08
Assignee:Peter Schuster % Done:

100%

Category:Forum
Target version:1.9.2
Votes: 0

Description

When displaying the form to create a new post, the extension actually uses the template to create a new thread.
While the forms are virtually identical, changing something only for new posts or only for new topics is not possible with just templates.

In pi1/class.tx_mmforum_pi1.php in the function new_post() at line 2724:

                    $previewContent = $this->cObj->substituteMarkerArrayCached($previewTemplate, $previewMarker);
                }

->        $template = $this->cObj->fileResource($conf['template.']['new_topic']);
                $template = $this->cObj->getSubpart($template, "###NEWTOPIC###");
        $template = $this->cObj->substituteSubpart($template, '###TITLE_SUBPART###', '');

has to be changed to

$template = $this->cObj->fileResource($conf['template.']['new_post']);

Regards

Nils

Associated revisions

Revision 32983
Added by Peter Schuster about 3 years ago

[#BUGFIX] Wrong template was used in pi1->new_post() (fixes #7652, thanks to Nils Blattner)

Revision 8128d1fc
Added by Peter Schuster about 3 years ago

[#BUGFIX] Wrong template was used in pi1->new_post() (fixes #7652, thanks to Nils Blattner)

git-svn-id: https://svn.typo3.org/TYPO3v4/Extensions/mm_forum/trunk@32983 735d13b6-9817-0410-8766-e36946ffe9aa

Revision 37834
Added by Peter Schuster almost 3 years ago

[#BUGFIX] Fix new_post template (follow up to r32983) and clean up of methods post_edit and new_post (fixes #7652)

Revision 41341b90
Added by Peter Schuster almost 3 years ago

[#BUGFIX] Fix new_post template (follow up to r32983) and clean up of methods post_edit and new_post (fixes #7652)

git-svn-id: https://svn.typo3.org/TYPO3v4/Extensions/mm_forum/trunk@37834 735d13b6-9817-0410-8766-e36946ffe9aa

History

Updated by Peter Schuster about 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Thanks Nils. I fixed it in r32983.
There were actually some more accidental copy&paste leftovers from new_topic() method.

Updated by Nils Blattner about 3 years ago

Actually I forgot to add that the new_post.html template is messed up too.
Simply copy/pasting the ###NEW_TOPIC### section over will fix it tough.

Updated by Peter Schuster about 3 years ago

  • Status changed from Resolved to Accepted
  • % Done changed from 100 to 50

Ok. I opened it again and gone take a look at it.

Updated by Peter Schuster about 3 years ago

  • Target version set to 1.9.2

Updated by Peter Schuster almost 3 years ago

  • Due date set to 2010-09-08
  • Status changed from Accepted to Resolved
  • Assignee set to Peter Schuster
  • % Done changed from 50 to 100

Also available in: Atom PDF