Project

General

Profile

Actions

Task #77039

closed

Epic #73121: Render() method arguments should be moved to initializeArguments()

Task #76914: Move method arguments to initializeArguments() in ext:fluid

DateViewHelper: Move method arguments to initializeArguments() in ext:fluid

Added by Roberto Torresani almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2016-07-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php:105: public function render($date = null, $format = '', $base = null)
sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php:264: $this->assertEquals($expected, $this->subject->render($date, $format));
sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php:308: $this->assertEquals($expected, $this->subject->render($date, $format));
sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php:345: $this->assertEquals($expected, $this->subject->render($timestamp, $format));


Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Task #77009: DateViewHelper: Move method arguments to initializeArguments() in ext:fluidClosedAnna Färber2016-07-10

Actions
Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48911

Actions #2

Updated by Roberto Torresani almost 8 years ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48911

Actions #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48911

Actions #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48911

Actions #6

Updated by Riccardo De Contardi almost 8 years ago

  • Category set to Code Cleanup
Actions #7

Updated by Roberto Torresani almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49097

Actions #9

Updated by Jan Haffner almost 8 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF