Bug #78116
closed
extbase setting statement directly should support Doctrine\DBAL\Statement
100%
Description
With the change to doctrine DBAL extbase direct query
should also support "\Doctrine\DBAL\Statement" as prepared statements
instead of only "\TYPO3\CMS\Core\Database\PreparedStatement"
especially as that class uses DatabaseConnection which is deprecated.
See the if condition in getObjectDataByRawQuery
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php#l399
which doesn't check for possible doctrine prepared statement.
Updated by Wouter Wolters over 7 years ago
Extbase is not finished yet with DBAL migration. See https://review.typo3.org/#/c/49584/
Updated by Andreas Allacher over 7 years ago
Ah. Didn't know it wasn't finished yet.
However, the mentioned review doesn't take care of this either (yet).
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Gerrit Code Review over 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50178
Updated by Benni Mack over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 25949707cc73f979eb57e3dbe0709d3a23f11704.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed