Project

General

Profile

Actions

Bug #78985

closed

Flexform inline elements with dots need escaping

Added by Tabea Oertel over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2016-12-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If you are using TCA fields with dots the dots need to be escaped because javascript cant find the element if the id has a dot inside.

The bug occurs if you have an element linke <settings.testImage> from type "inline" with "maxitems" set to 1 and minitems set to 1.
The button to add an image disapears when adding one image and does not show up again, when deleting that image. Thats a huge problem when that field is a required field because u cant add an image again, but you cant save the content element, too.

The Problem is located in file sysext/backend/Resources/Public/JavaScript/jsfunc.inline.js in following functions:

  • hideElementsWithClassName
  • showElementsWithClassName

Inside the functions the 'parentObject' need to be escaped through the available function this.escapeObjectId() to work properly.

Like this:

    hideElementsWithClassName: function (selector, parentElement) {
        TYPO3.jQuery('#' + this.escapeObjectId(parentElement)).find(selector).fadeOut(200);
    },

    showElementsWithClassName: function (selector, parentElement) {
        TYPO3.jQuery('#' + this.escapeObjectId(parentElement)).find(selector).fadeIn(200);
    },

This bug occurs with Version 7.6

Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51014

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51014

Actions #3

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52082

Actions #4

Updated by Georg Ringer about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF