Bug #80036
open
FAL translation with TCA maxitems set
0%
Description
There is a bug with "Localize all records" and "Synchronize with original language".
In my TCA a have a FAL field with maxitems=1.
If I go to the translated record and hit one of those buttons, I get the error message "A maximum of 1 child records are allowed.".
However, after reloading the form, it seems the FAL record is translated.
Updated by
Updated by Georg Ringer about 7 years ago
- Category changed from FormEngine aka TCEforms to Localization
- Status changed from New to Accepted
- Is Regression changed from No to Yes
- Sprint Focus set to Stabilization Sprint
Updated by Alexander Stehlik about 7 years ago
I can confirm this bug. It also affects version 7.
Updated by Stefan Herndler about 6 years ago
This is a JS error message and luckily does not affect the ajax request to localize any child records.
Affected line of code: typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.inline.js:155
The script fires an error notification if the number of childs is equal or greater than the defined 'maxitems' of the TCA (only 'below max' is valid).
Typo3 version is 8.7.10
Updated by Gerrit Code Review almost 6 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57124
Updated by Eduard Luft almost 6 years ago
Gerrit Code Review wrote:
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57124
Patch for TYPO3_7.6!
By removing the redundant isBelowMax condition in domAddNewRecord the localize or synchronize function will no longer throw a fake message for elements with the tca setting 'maxitems=1'. I removed the message output completely in domAddNewRecord, because the new button disappears if the 'maxitems' amount is reached. Also adding the 'isBelowMax' condition in synchronizeLocalizeRecords to prevent an fatal error by create a new element followed by the localize button.
Updated by Peter Rauber almost 6 years ago
Possibly another ticket duplicates this one: https://forge.typo3.org/issues/82880
Seems a little more progress has been done there.
Updated by Riccardo De Contardi almost 6 years ago
- Related to Bug #82880: Synchronize inline records triggers maxItemsError added
Updated by Wouter Wolters over 5 years ago
- Status changed from Under Review to New
Updated by Steffen G/G over 4 years ago
Its kind of wrong question. isBelowMax tests recordCount >= this.data.config[objectPrefix].max.
While configured in TCA maxItem are allowed.
So lets ask if isNotAboveMax e.g.
!(recordCount > this.data.config[objectPrefix].max)
Updated by Lidia Demin over 3 years ago
Can still confirm this issue on TYPO3 9.5.20 with PHP 7.2
Updated by Marcin Sągol 6 months ago
Could you please provide more information, such as:
- what language configuration for the site do you have
- attach the TCA for the problematic field
I tested it on T3-dev (13) by modifying the core image field and setting maxitems to 1 or 2, and enabling the showSynchronizationLink and showAllLocalizationLink options. In both cases, the translation worked fine for me (a page with 2 languages available). There were no JS errors displayed in the TYPO3 panel.
Updated by Lidia Demin 6 months ago
Sadly, I can't provide information about this issue anymore. Maybe one of the other contributors can.