Feature #8046

action controller doesn't show all error messages

Added by Martin Kutschker almost 3 years ago. Updated 10 months ago.

Status:Rejected Start date:2010-06-03
Priority:Should have Due date:
Assignee:- % Done:

0%
Category:Extbase: Validation
Target version:-
Has patch:No Tags:
Votes: 0

Description

The reason is that property errors contain other errors. As this could occur in other situations as well solve this by making the getMessage() method return all messages of child errors.

Example output from one of my extensions:

BEFORE:

An error occurred while trying to call Tx_BallroomDancing_Controller_TextController->showAction().
Error: Validation errors for argument "text".

AFTER:

An error occurred while trying to call Tx_BallroomDancing_Controller_TextController->showAction().
Error: Validation errors for argument "text"; Validation errors for property "year"; The given subject was not in the valid range (1900 - 2100).

Note: the patch adds a nl2br() to ease readability with HTML (how to detect the output format?)

showAllActionErrors.patch (1.4 kB) Martin Kutschker, 2010-06-03 12:52

History

#1
Updated by Mr. Hudson almost 2 years ago

Patch set 1 of change I1b38ba7dda2061f72e2356885e33fc5c81657074 has been pushed to the review server.
It is available at http://review.typo3.org/2656

#2
Updated by Stefan Neufeind almost 2 years ago

Sent to review without the nl2br() for now. I don't think nl2br() would be good to have (as you write yourself). But returning child-errors would definitely be a good thing to have.

#3
Updated by Sebastian Kurfuerst almost 2 years ago

  • Status changed from New to Under Review
  • Has patch set to No

#4
Updated by Bastian Waidelich almost 2 years ago

  • Category set to Extbase: Validation

#5
Updated by Bastian Waidelich almost 2 years ago

  • Tags set to forward-port

#6
Updated by Mr. Hudson almost 2 years ago

Patch set 2 of change I1b38ba7dda2061f72e2356885e33fc5c81657074 has been pushed to the review server.
It is available at http://review.typo3.org/2656

#7
Updated by Sebastian Kurfuerst almost 2 years ago

  • Tags deleted (forward-port)

Hey Bastian,

this change does not need to be forward ported, as it is included in FLOW3 with the new Property Mapper anyhow.

Greets,
Sebastian

#8
Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/2656

#9
Updated by Felix Oertel 10 months ago

  • Status changed from Under Review to Rejected

We don't need this with the new propertyMapper anymore.

Also available in: Atom PDF