Project

General

Profile

Actions

Bug #81291

open

Flash messages "info.elementAlreadyModified" added multiple times

Added by Kevin Ditscheid almost 7 years ago. Updated 9 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2017-05-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

When visiting a record with Inline relations that has been sent to a review stage, the flash message with the label LLL:EXT:workspaces/Resources/Private/Language/locallang.xlf:info.elementAlreadyModified is added not only for the opened record itself, but for every inline record attached to it, that has been send to another stage.
This is because of the \TYPO3\CMS\Workspaces\Hook\BackendUtilityHook->makeEditForm_accessCheck hook not checking, if the message has already been added to the queue, or if the record that is checked is an inline record of the actual record.

I think the hook can not provide this functionality of not sending the message for inline records, because it can not know of this, because it gets no further information about the record it processes at that time.

The annoying thing about this is, that there will be as much flash messages as there are inline relations, rendering the edit view into a scroll fest.

One can test this by adding a simple record with file relations, creating a new workspaces stage by changing and saving it and sending it to another stage than \TYPO3\CMS\Workspaces\Service\StagesService::STAGE_EDIT_ID and finally revisiting the record.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81290: Wrong type hint in BackendUtilityHookClosed2017-05-22

Actions
Actions #1

Updated by Kevin Ditscheid almost 7 years ago

  • Related to Bug #81290: Wrong type hint in BackendUtilityHook added
Actions #2

Updated by Benni Mack 9 months ago

  • Sprint Focus set to On Location Sprint
Actions

Also available in: Atom PDF