Bug #81591
closedTranslation of email finisher subject
100%
Description
Hi there,
as stated in the documentation here:
https://docs.typo3.org/typo3cms/drafts/code.tritum.de/TYPO3.CMS/Form_Documentation/Concepts/Index.html#concepts-frontendrendering-translation-finishers
the subject of the email finishers should translatable via:
<!-- Form Finishers -->
<trans-unit id="finisher.EmailToReceiver.subject">
<source>My own receiver subject</source>
</trans-unit>
<trans-unit id="finisher.EmailToSender.subject">
<source>My own sender subject</source>
</trans-unit>
But is still uses the default subject used in the YAML-File:
finishers:
-
identifier: EmailToReceiver
options:
subject: 'Message from website'
recipientAddress: test@test.com
recipientName: 'Testname'
senderAddress: noreply@test.com
senderName: '{firstname} {lastname}'
replyToAddress: '{email}'
carbonCopyAddress: ''
blindCarbonCopyAddress: ''
format: html
attachUploads: 'false'
translation:
language: 'en'
-
identifier: EmailToSender
options:
subject: 'Thank you for your mail'
recipientAddress: '{email}'
recipientName: ''
senderAddress: noreply@test.com
senderName: 'Testname'
replyToAddress: ''
carbonCopyAddress: ''
blindCarbonCopyAddress: ''
format: html
attachUploads: 'false'
Updated by Gerrit Code Review almost 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363
Updated by Ralf Zimmermann almost 7 years ago
- Assignee set to Ralf Zimmermann
You are right. There is a bug. For now, the translation key is calculated from the finisher implementation class name (like EmailFinisher) without the "Finisher" suffix.
This is why a translation keys like "finisher.EmailToReceiver.subject" won't work because EXT:form searches for "finisher.Email.subject" (the implementation class name ist called EmailFinisher.php).
Updated by Gerrit Code Review almost 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363
Updated by Gerrit Code Review over 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53843
Updated by Ralf Zimmermann over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 615d2daeea420e1acd578dffab9c49bd7071528b.
Updated by Mathias Brodala over 6 years ago
- Has duplicate Bug #82087: Finisher identifier unused for translations added