Project

General

Profile

Actions

Bug #81591

closed

Translation of email finisher subject

Added by Wolfgang Freund almost 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2017-06-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi there,

as stated in the documentation here:
https://docs.typo3.org/typo3cms/drafts/code.tritum.de/TYPO3.CMS/Form_Documentation/Concepts/Index.html#concepts-frontendrendering-translation-finishers

the subject of the email finishers should translatable via:

<!-- Form Finishers -->
            <trans-unit id="finisher.EmailToReceiver.subject">
                <source>My own receiver subject</source>
            </trans-unit>
            <trans-unit id="finisher.EmailToSender.subject">
                <source>My own sender subject</source>
            </trans-unit>

But is still uses the default subject used in the YAML-File:

finishers:
  -
    identifier: EmailToReceiver
    options:
      subject: 'Message from website'
      recipientAddress: test@test.com
      recipientName: 'Testname'
      senderAddress: noreply@test.com
      senderName: '{firstname} {lastname}'
      replyToAddress: '{email}'
      carbonCopyAddress: ''
      blindCarbonCopyAddress: ''
      format: html
      attachUploads: 'false'
      translation:
        language: 'en'
  -
    identifier: EmailToSender
    options:
      subject: 'Thank you for your mail'
      recipientAddress: '{email}'
      recipientName: ''
      senderAddress: noreply@test.com
      senderName: 'Testname'
      replyToAddress: ''
      carbonCopyAddress: ''
      blindCarbonCopyAddress: ''
      format: html
      attachUploads: 'false'

Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #82087: Finisher identifier unused for translationsClosed2017-08-11

Actions
Actions #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363

Actions #2

Updated by Ralf Zimmermann almost 7 years ago

  • Assignee set to Ralf Zimmermann

You are right. There is a bug. For now, the translation key is calculated from the finisher implementation class name (like EmailFinisher) without the "Finisher" suffix.
This is why a translation keys like "finisher.EmailToReceiver.subject" won't work because EXT:form searches for "finisher.Email.subject" (the implementation class name ist called EmailFinisher.php).

Actions #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53363

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53843

Actions #5

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Mathias Brodala over 6 years ago

  • Has duplicate Bug #82087: Finisher identifier unused for translations added
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF