Project

General

Profile

Actions

Bug #82496

closed

Remove duplicate caching of PageTS in Extbase's Typo3DbBackend

Added by Alexander Schnitzler over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Target version:
Start date:
2017-09-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.0
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbBackend fetches the PageTS via BackendUtility::getPagesTSconfig($storagePage); in line 719.

This is a bug because that method already returns cached data and the cache algorithm inside that method is even better than the one Extbase comes up with.
If different pages have the same PageTS, it will only be cached once. As soon as Extbase kicks in, it fetches the PageTS from the BackendUtility and stores a copy of it in a static property. On top, Extbase always copies the PageTS, even if the PageTS for different pages is the same.

In this case, the cache can simply be removed at all.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #82474: Disable pageTSconfig Caching in ExtbaseClosed2017-09-13

Actions
Actions #1

Updated by Alexander Schnitzler over 6 years ago

  • Related to Bug #82474: Disable pageTSconfig Caching in Extbase added
Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54151

Actions #3

Updated by Alexander Schnitzler over 6 years ago

  • Assignee changed from Alexander Opitz to Alexander Schnitzler
Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54151

Actions #5

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54185

Actions #6

Updated by Anonymous over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF