Project

General

Profile

Actions

Bug #84227

closed

page tsconfig file includes (and record field) are reversed in FE

Added by Markus Klein about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2018-03-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Test case 1

Consider two tsconfig files:

foo1.tsconfig

foo = 1

foo2.tsconfig

foo =2

Include them on a page in this order: foo1, foo2

The info module says that on this page the resulting page TSconfig is foo = 2, which is correct.

Debugging frontend (TypoScriptFrontendController::getPagesTSconfig) though, reveals that foo = 1 in FE.

Test case 2

Include the above foo1.tsconfig file and add foo = 2 in the TSconfig field of the page record.
The same behaviour as above can be observed.

Analysis

The reason is that page TSconfig resolution is implemented differently for FE and BE.

BE walks the rootline and collects TSconfig from top to bottom, whereas FE walks from bottom to top and reverses the array afterwards, BUT the individual tsconfig_includes of each pages are always fetched in the given order in the page record, which mean that their order is reversed too in FE context causing the observed behaviour above.

Actions #1

Updated by Markus Klein about 6 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56122

Actions #3

Updated by Markus Klein about 6 years ago

  • Subject changed from page tsconfig file includes are reversed in FE to page tsconfig file includes (and record field) are reversed in FE
  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56127

Actions #5

Updated by Markus Klein about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF