Project

General

Profile

Actions

Bug #84512

closed

styles.templates.*RootPath variable results should be ignored when empty

Added by Rasmus Larsen about 6 years ago. Updated about 4 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
Category:
Fluid Styled Content
Start date:
2018-03-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In the fluid_styled_content builtin extension a variable $styles.templates.templateRootPath/$styles.templates.partialRootPath/$styles.templates.layoutRootPath exists that can be used to override templates. (in fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.txt)

Unfortunately I've found that if undefined/empty, this variable will be used anyway, resulting in an empty entry in the paths:
array(2) { [0]=> string(114) "/mnt/web-data/sites/konto-experimental.systime.dk/web/typo3/sysext/fluid_styled_content/Resources/Private/Layouts/" [10]=> string(0) "" }

This doesn't make anything break as such, but atleast in the case of partialRootPaths the 10 entry is evaluated first in typo3fluids resolveFileInPaths function, which causes two useless is_file requests to be made to:
"Default.html"
"Default"

In environments with slow stat calls (network file systems and the like) this can take a ms or more, and it just generally doesn't seem like the behavior one would want.

I believe the variable should be checked and, if empty, should not be used.

Actions #1

Updated by Rasmus Larsen about 6 years ago

  • Assignee changed from Claus Due to Benjamin Kott
Actions #2

Updated by Benni Mack almost 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #3

Updated by Georg Ringer about 4 years ago

  • Status changed from New to Rejected

Thanks for the issue. I have talked with Claus Due about this and even though your use is valid I am rejecting the issue as an empty path could be also a valid path as well.

Actions

Also available in: Atom PDF