Feature #85114
closed
modestbranding in YouTube
100%
Description
Hello.
Our customer needs to set the modestbranding attribute for YouTube videos. This attribute is not supported by YouTubeRenderer.php. So i add this code:
if (isset($options['relatedVideos'])) {
$urlParams[] = 'rel=' . (int)(bool)$options['relatedVideos'];
}
/*ADD*/
if (isset($options['modestbranding'])) {
$urlParams[] = 'modestbranding=' . (int)(bool)$options['modestbranding'];
}
/*ADD [END]*/
if (!isset($options['enablejsapi']) || !empty($options['enablejsapi'])) {
$urlParams[] = 'enablejsapi=1&origin=' . rawurlencode(GeneralUtility::getIndpEnv('TYPO3_REQUEST_HOST'));
}
Is ist possible to integrate this in the core?
Files
Updated by Frans Saris almost 6 years ago
Sure, please push a patch to or review system.
Could you please add a link to the YouTube docs here. Did we miss this option or is this new?
Updated by Guido Schmechel almost 6 years ago
Found the info at https://developers.google.com/youtube/player_parameters?hl=en#modestbranding
There are a lot more options which aren't implemented but which we could handle via "additionalAttributes"? What do you say?
Best, Guido
Updated by Reindl Bernd almost 6 years ago
Guido Schmechel wrote:
Found the info at https://developers.google.com/youtube/player_parameters?hl=en#modestbranding
There are a lot more options which aren't implemented but which we could handle via "additionalAttributes"? What do you say?
Best, Guido
At the moment i only need modestbranding. But full support would be nice.
Updated by Reindl Bernd almost 6 years ago
- File YouTubeRenderer.php YouTubeRenderer.php added
Frans Saris wrote:
Sure, please push a patch to or review system.
Could you please add a link to the YouTube docs here. Did we miss this option or is this new?
Sorry. But i dont know how to patch a file. You can find the edited File attached. Row 123 - 125.
Updated by Benni Mack almost 6 years ago
- Target version changed from 8.7.15 to 8.7.19
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57273
Updated by Guido Schmechel almost 6 years ago
I decide to set this as "Task" because of the setting from Benni to support 8 and 9. This just include the "modestbranding" parameter. We should always think about fullsupport, but not in this ticket ;-)
Updated by Frans Saris almost 6 years ago
- Complexity set to easy
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review almost 6 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57304
Updated by Guido Schmechel almost 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 301bde3e6053b3efa25c6a92581f99b3ff317a95.