Bug #85656: After logout from install tool the screen suggests to create the ENABLE* file, but it still exists due to KEEP_FILE - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #85656

closed

After logout from install tool the screen suggests to create the ENABLE* file, but it still exists due to KEEP_FILE

Added by Markus Klein over 5 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Install Tool

Target version:

Candidate for patchlevel

Start date:

2018-07-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

For testing purposes I have a ENABLE_INSTALL_TOOL file with the "KEEP_FILE" content.
After logging out of the standalone install tool, the screen is shown as if the file does not exist.
I think there is a missing check for the permanent ENABLE_INSTALL_TOOL file.

Actions

Copy link

Updated by Guido Schmechel over 5 years ago

Hi Markus,

this would maybe a simple check in Http/RequestHandler.php

            if ($this->checkEnableInstallToolFile()) {
                $response = $controller->showLoginAction($request);
            } else {
                $response = $controller->showEnableInstallToolFileAction($request);
            }

But i think this a UX topic. If there is a KEEP_FILE string in the ENABLE_INSTALL_TOOL, the "lock" button should not be visible.

Actions

Copy link

Updated by Susanne Moog over 5 years ago

Target version changed from 9 LTS to Candidate for patchlevel

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63831

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63831

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63853

Actions

Copy link