Task #8734

Clean up SetupController and its resources

Added by Robert Lemke almost 3 years ago. Updated 9 months ago.

Status:Resolved Start date:2010-07-08
Priority:Should have Due date:
Assignee:Karsten Dambekalns % Done:

100%
Category:-
Target version:-
Votes: 0

Description

The Backend\SetupController is currently a real mess. FLOW3's validation is neglected, the Fluid template uses inline styles (well, it uses the "error" layout to display the setup screen) and so on. Also the import functionality should be extracted to its own class.

Bottomline: Make this a clean controller, properly implemented

phoenix_task_8734.patch (20.2 kB) Christian Mueller, 2010-08-11 08:58

phoenix_task_8734_v2.patch - v2 which puts the footer into a partial and uses that in Login and Setup. (21.7 kB) Christian Mueller, 2010-08-11 18:53

phoenix_task_8734_v3.patch (21.1 kB) Karsten Dambekalns, 2010-08-16 11:20

Related issues

related to TYPO3.Neos - Task #8731: Meaninful messages in setup controller Resolved 2010-07-07

History

#1
Updated by Christian Mueller almost 3 years ago

  • Assignee set to Christian Mueller

#2
Updated by Christian Mueller almost 3 years ago

  • Status changed from New to Accepted

#3
Updated by Sebastian Kurfuerst almost 3 years ago

Hey Christian,

I just wanted to ask what the current status on this issue is. Do you have any open questions, or is there anything we can do to support you solving this issue? You'll find us in the usual Jabber chatroom.

Thanks in advance for a short status!

Greets,
Sebastian

#4
Updated by Christian Mueller almost 3 years ago

See also Scrum protocol of today. I am mostly working on management view and Bastian supported this by saying that probably Robert wants to have a word in this refactoring...

#5
Updated by Christian Mueller almost 3 years ago

And here finally a patch for it.

Some notes:

I took the footer from login to make it a bit similar, I would like to pack the footer into some separate file and reuse it in both with fluid but do not know how that is possible.

I copied the TransparentBackground Stuff from Frontend to backend, so we have a duplicate file now, but as they will replaced at some point anyway at least we do not mix file reference from backend to frontend.
So you need to copy
\Packages\Application\TYPO3\Resources\Public\Frontend\Error\Images\TransparentBackgroundWithRed.png to
\Packages\Application\TYPO3\Resources\Public\Backend\Media\Images\Backgrounds\TransparentBackgroundWithRed.png

#7
Updated by Robert Lemke almost 3 years ago

  • Status changed from Accepted to Needs Feedback
  • Assignee changed from Christian Mueller to Karsten Dambekalns

#8
Updated by Karsten Dambekalns almost 3 years ago

This is the patch that will be committed. Some tiny changes only.

#9
Updated by Karsten Dambekalns almost 3 years ago

  • Status changed from Needs Feedback to Resolved
  • % Done changed from 0 to 100

Resolved as of r4973.

#10
Updated by Robert Lemke about 2 years ago

  • Project changed from Core Team to Base Distribution
  • Target version deleted (593)

#11
Updated by Robert Lemke 9 months ago

  • Project changed from Base Distribution to TYPO3.Neos

Also available in: Atom PDF